Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fund and quote_fund for wallet funding #47

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Support for fund and quote_fund for wallet funding #47

merged 12 commits into from
Nov 27, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Nov 22, 2024 •
edited
Loading

What changed? Why?

  • Creates new crypto_amount and fiat_amount classes to wrap the underlying models, as well as fund_operation and fund_quote.
  • Updates wallet_address and wallet for new fund and quote_fund functions.

Testing

  • Unit tests

Qualified Impact

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the base branch from master to v0.11.0 November 22, 2024 17:57
alex-stone
alex-stone approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@alex-stone alex-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are some minor differences in the amount / types and rendering here, but we can always align those later

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit 1d02804 into v0.11.0 Nov 27, 2024
5 checks passed
@alex-stone alex-stone mentioned this pull request Nov 27, 2024
Merged
alex-stone added a commit that referenced this pull request Nov 27, 2024
@alex-stone @rohan-agarwal-coinbase @howard-at-cb
Merge pull request #53 from coinbase/v0.11.0
679eafb 
* Fix Asset from_model bug to use passed in asset_id when initializing (#46)

* Support for fund and quote_fund for wallet funding (#47)

* Fix quote fund to properly pass in normalized amount (#50)

* Contract webhook support (#52)

* contract activity webhook support

* Update webhook.py

* Update webhook_factory.py

* chore: Prep v0.11.0 release (#51)

---------

Co-authored-by: rohan-agarwal-coinbase <[email protected]>
Co-authored-by: cb-howardatcb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stone alex-stone alex-stone approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @alex-stone