Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for additional uint and int types #41

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fix for additional uint and int types #41

merged 4 commits into from
Nov 7, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Nov 7, 2024 •
edited
Loading

What changed? Why?

  • The slot0 and observe functions in uniswap pools use int24, int56, uint160. We're missing more types like this but this PR adds support for just 3 for now.
  • Updates the OpenAPI generated client

Testing

  • Updated unit tests
  • E2E tested with the BE changes to ensure that i can call slot0 and observe on dex pools

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Nov 7, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 7, 2024
View reviewed changes
cdp/client/api_client.py Dismissed Show dismissed Hide dismissed
John-peterson-coinbase
John-peterson-coinbase approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Changelog update when you push the patch version. Thanks cc: @rohan-agarwal-coinbase

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit 92a19c4 into master Nov 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @John-peterson-coinbase