chore: fix npm scripts, linting and bump lint packages #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-peterson-coinbase
approved these changes
Jan 30, 2025
0xRAG
added a commit
that referenced
this pull request
Jan 31, 2025
John-peterson-coinbase
pushed a commit
that referenced
this pull request
Feb 1, 2025
John-peterson-coinbase
added a commit
that referenced
this pull request
Feb 1, 2025
* 0.1.0 initial scaffolding (#175) * chore: fix lint (#177) * chore: migrate basename action (#176) * chore: CDP, Farcaster, ERC721 action providers (#181) * CDP, Farcaster, ERC721 ActionProvider * README erc721 * chore: migrate erc20 action (#182) * 0.1.0(ts): morpho actions (#184) * chore: migrate erc20 getBalance (#186) * chore: fix npm scripts, linting and bump lint packages (#179) * chore: migrate erc721 getBalance (#188) * chore: migrate wrap eth action (#189) * chore: langchain helper to convert actions to tools (#190) * 0.1.0(ts): wow actions (#191) * chore: migrate get wallet details (#192) * 0.1.0(ts): twitter actions (#193) * chore: eslint import order (#194) * chore: map chainId to networkId (#196) * chore: fix typo (#197) * chore: migrate deploy token (#198) * 0.1.0(ts): deploy contract (#201) * first pass adding deploy contract cdp action * linting * the lost file * tests * 0.1.0(ts): adding eth balance to wallet details (#199) * feat: Client side metrics (#195) * 0.1.0(ts): deploy nft (#200) * chore: rename typescript files and folders (#203) * chore: split out cdp wallet and cdp api actions (#204) * chore: migrate trade action (#208) * twitter chatbot example (#205) * 0.1.0(ts): farcaster example (#206) * chore: cdpApiActionProvider usage (#211) * chore: prefix action name (#210) * chore: set default action provider to wallet action provider (#212) * 0.1.0(ts): wallet native token transfer (#213) Co-authored-by: John Peterson <[email protected]> * fix: use prefix notation that plays nicely with langchain (#217) * feat: support custom action provider (#214) * 0.1.0(ts): cdp wallet provider (#218) Co-authored-by: John Peterson <[email protected]> * feat: CdpWalletProvider sendTransaction * fix cdp provider config fields * docs + dir structure refactor * add language level readmes * release ready! * fix agentkit-langchain unit tests * fix python unit test GHA poetry relative paths * update poetry lock files --------- Co-authored-by: Ryan Gilbert <[email protected]> Co-authored-by: Chris Gerber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
After running
npm run lintincdp-agentkit-corelocally, I noticed there were no lint errors thrown, even though there were lint errors in files within thepythfolder. I discovered that zsh doesn't play nicely with the glob in the lint script, so I added escaped quotes around the glob and now zsh picks up the files correctly. Bash continues to work as expectedI then fixed the remaining eslint errors in the
pythfolder, as well as bumped the TS eslint packages so that this warning goes away: