Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify internal package dependencies #155

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Jan 23, 2025

What changed? Why?

Uses Turbo's Internal Packages so that we don't have to manually bump dependency versions in packages that depend on each other.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 23, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xRAG 0xRAG force-pushed the chore/turbo-packages branch from 3b7a555 to 2925be0 Compare January 23, 2025 23:01
@0xRAG 0xRAG force-pushed the chore/turbo-packages branch from 2925be0 to 9a3d7b0 Compare January 23, 2025 23:15
@@ -38,8 +38,7 @@
"langchain"
],
"dependencies": {
"@coinbase/cdp-agentkit-core": "^0.0.13",
"@coinbase/coinbase-sdk": "^0.14.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is listed as a peerDependency, it does not need to be included here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants