Python 3 support #67
Merged
Python 3 support #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 does not differentiate betten int and long so the PyInt_ functions must be replaced with PyLong_. Macros from cx_Oracle project.
The izip function fron itertools was removed from Python 3, use of zip is recommended.
TypeError and NotImplementedError are build ins
long was removed in Python 3, use int in its place.
The build in reduce function was removed in Python 3 and must be imported from functools.
Due to the different methods that Python 2 and 3 represent strings it is necessary to encode the filename passed to the readMps function which can then be converted into a char* pointer for use in C. Since strings do not share a type in Python 2 and 3 the filename argument of the readMps function must not be typed.
This may break the bdist_mpkg and bdist_wininst commands
|
I posted a beta version with Python 3 support to Pypi: There is a binary wheel for Windows, but you still need to build Cbc before installing on Linux and OS X. |
|
I seem to have figured out the bug that prevented this from building with Cython 0.29. I re-generated the files once again and pushed a binary wheel up for Python 3.7 on Windows. |
…e csr_matrixPlus type introduced in CyLP
|
Thanks for the PR. In testing, I found a bug that arises with recent versions of SciPy. I fixed that and am now merging to master. There are still some outstanding bugs that should be fixed, but these can be fixed in master and don't affect use in most cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of #28. I re-generated the Cython files with Cython 0.23.3 (which seems to be the last version used by @jjhelmus). I can build and install. I get an error Ican't interpret with the most recent version of Cython (0.29.6). Unfortunately, I'm not an expert on Python 3 or Cython. I'll continue to debug, but if anyone wants to grab this and try their luck, I thought I would throw it out there. I'm also getting some deprecation warnings and a few other strange errors when testing, although thing seems to be working for the most part.