Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in make_chart #1251

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix race condition in make_chart #1251

merged 1 commit into from
Jan 9, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Jan 9, 2024

Closes #1249

milesgranger
milesgranger approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks! 👍

@milesgranger milesgranger merged commit 660ff06 into main Jan 9, 2024
15 of 16 checks passed
@milesgranger
Copy link
Contributor

Failing test not related:

FAILED tests/tpch/test_dask.py::test_query_1 - NotImplementedError: 'numeric_only=False' is not implemented in Dask.

Part of #1250

@milesgranger milesgranger deleted the move_charts_to_lock branch January 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesgranger milesgranger milesgranger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed ⚠️ - TPC-H - FileExistsError 'charts'
2 participants
@fjetter @milesgranger