Add support for ImageLoader.newBuilder(). #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
force-pushed
the
colin/shared_memory_cache
branch
from
de4d612 to
9149e34
Compare
colinrtwhite
commented
Feb 7, 2021
| @@ -52,9 +54,6 @@ import java.io.File | |||
| * | |||
| * Image loaders are designed to be shareable and work best when you create a single instance and | |||
| * share it throughout your app. | |||
| * | |||
| * It's recommended, though not required, to call [shutdown] when you've finished using an image loader. | |||
There was a problem hiding this comment.
Removed this and clarified that you probably don't need to shut down image loaders in the shutdown method doc.
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Support ImageLoader.newBuilder and sharing memory caches between image loaders. * Add tests. * Fix imports. * Docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #614.
Supports building a new
ImageLoaderinstance using an existing instance as a base. This shares resources + configuration between the two instances.TODO: Needs more tests.