Launch the Interceptor chain on the main thread by default. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Aug 29, 2020
| @@ -15,17 +17,38 @@ import okhttp3.HttpUrl | |||
| import okhttp3.Request | |||
| import okhttp3.ResponseBody | |||
|
|
|||
| internal class HttpUrlFetcher(private val callFactory: Call.Factory) : Fetcher<HttpUrl> { | |||
| internal class HttpUriFetcher(callFactory: Call.Factory) : HttpFetcher<Uri>(callFactory) { | |||
There was a problem hiding this comment.
Restoring the optimization to call HttpUrl.get as part of Fetcher.fetch instead of part of Mapper.map as Fetcher.fetch is always called on a background thread.
Jawnnypoo
approved these changes
Aug 31, 2020
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Execute Interceptors synchronously by default. * Re-add HttpFetcher optimization. * Tweaks. * Docs. * Formatting. * Docs. * Add support for addLastModifiedToFileCacheKey flag. * Use runBlockingTest. * Nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default behaviour of the interceptor chain to be launched on the main thread by default. Why do this:
Interceptorsto be execute on the main thread synchronously if preferred.Interceptorscan also control which requests check the memory cache on the main thread by usingwithContextto change the current dispatcher when callingInterceptor.Chain.proceed.0.12.0. This realigns with that behaviour, but allows consumers to move the check off the main thread if they want maximum performance.This PR adds two new flags to
ImageLoader.Builder:launchInterceptorChainOnMainThread: Enables/disables launching the interceptor chain on the main thread.addLastModifiedToFileCacheKey: If the memory cache check occurs on the main thread, callingFile.lastModifiedcan cause a strict mode violation. This flag disables callingFile.lastModified. See Add option to disable adding File.lastModified to the cache key. #415 for context.Fixes: #280