Add Request.parameters to support passing custom data through the image pipeline. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Sep 22, 2019
colinrtwhite
force-pushed
the
colin/custom_parameters
branch
from
9e8ff3f to
db8b961
Compare
|
@Jawnnypoo Going to make a couple more changes to this PR so I would hold off reviewing for the moment. |
|
@Jawnnypoo Okay, should be ready. Let me know what you think. |
Jawnnypoo
reviewed
Sep 24, 2019
Jawnnypoo
reviewed
Sep 24, 2019
Jawnnypoo
reviewed
Sep 24, 2019
Jawnnypoo
approved these changes
Sep 24, 2019
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
…ge pipeline. (#119) * Add Request.parameters to support passing custom data through the image pipeline. * Fix tests. * Lazily init parameters map. Remove confusing extensions. * Add parameters to the cache key. * Reorganize. * Add note about parameters being part of the cache key. * Use ArrayMap. * Optimization. * Add Parameters class. * Fix tests. * Formatting. * Delegate equals, hashCode, and toString. * PR feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to add custom params to a request that are passed to
Fetchers andDecoders.I think this will be useful for adding params to extension libraries. For instance, we might eventually want to support loading a frame from a video as an extension library. This gives us a hook to pass in the time code.
EDIT: Ended up going forward with the video frame decoder idea here: #122.