Fix error handling #187
Merged
Fix error handling #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just check the last commit. The others are somehow still showing up but where from the last merge. I thought it was already merged thats why i created a new branch |
petrvecera
reviewed
Mar 2, 2022
| "app_quit", | ||
| { | ||
| distinct_id: clientId, | ||
| settings: { ...settings, coh2LogFileLocation: "" }, |
There was a problem hiding this comment.
That's pretty cool, i didn't know that you can write it like this
petrvecera
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back the error dialog
Improved /Fixed error event
removed coh2logfilepath