Refactor commanders list to include abilities #115
Conversation
| } | ||
|
|
||
| type CommanderAbility = { |
There was a problem hiding this comment.
Nice! I am so lazy with adding types but in the end it's really great to have them.
| return { | ||
| ...commander, | ||
| abilities: commander.abilities.sort((a, b) => { | ||
| return +a.commandPoints < +b.commandPoints ? -1 : 1; |
There was a problem hiding this comment.
Lol this is pretty cool trick to convert string to number! I didn't know that. Nice
Btw this compare doesn't return 0 if the elements are the same - which means it's gonna swap them in that case. I am not sure if that's a problem or not - technically not | just from the user perspective.
Also if you are comparing the numbers I think you can do just :
function compareNumbers(a, b) {
return a - b;
}
There was a problem hiding this comment.
Thanks for the tip, yeah, you are right, if both command points are the same they'll be swapped. I guess better to compare between the names then in case command points are equal.
| commanderDescription: string; | ||
| }; | ||
|
|
||
| const CommanderAbilitiesComponent = (props: CommanderAbilityProps) => { |
There was a problem hiding this comment.
Just a tip how you can nicely define a props with React functional components and typescript https://www.pluralsight.com/guides/defining-props-in-react-function-component-with-typescript
There was a problem hiding this comment.
Will take that into account next time, thanks!
|
Great work thank you! |
|
@petrvecera I'm wondering if you're interested to develop a discord bot using the data that's gathered by coh2ladders? I believe it would make an interesting project, no? 🤔 |
|
@R4md4c if you are interested in doing it, pleas try to create a new issue https://github.com/petrvecera/coh2ladders/issues where we could discuss this - the features etc. I personally don't have much extra time - so I don't think I would be contributing much into the bot source code. But I could help with providing and exposing the data from site. |
Hello,
This PR addresses the requirements in issue #73, by displaying the abilities in the commanders list screen in a horizontal fashion.
Also, I've managed to sort the abilities according to the command points, that sorting though will be applied to any screen that uses
getCommanderDataandgetCommanderByRacesfunctions.I'm not really experienced with web development, since I come from a mobile development background (native Android), so there might be better ways to do things that I've specified, let me know please in case there were any.
Testing:
getCommanderDataandgetCommanderByRacesfunctions.Screenshot:
