This repository has been archived by the owner on Dec 26, 2019. It is now read-only.
Track activity #182
Merged
Track activity #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| # Co-erces an HStore object of feature flags into a ruby model | |||
| class Features | |||
| include Virtus.model | |||
| attribute :check_in, Boolean, default: false | |||
| attribute :check_in, Boolean, default: true | |||
There was a problem hiding this comment.
Please don't change the default of this. It's off so that we can release from primary to production without worrying about exposing a half-finished feature.
There was a problem hiding this comment.
If you want to enable the check in feature for your user, do it through the rails console:
a = Account.find_by(email: "[email protected]")
a.features.check_in = true
a.save
There was a problem hiding this comment.
Ohhhh I read the issue and I thought it meant it wanted it turned on, but I gotcha I'll turn it back off
|
Looks good! Merge at your leisure! |
|
Resolves #178 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #178 and #177