[NEAT-739] 🙂 Handle bad names #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Feb 1, 2025
| @@ -327,6 +328,7 @@ def parse_table_lookup(raw: str) -> TableLookup: | |||
|
|
|||
|
|
|||
| def parse_rule(rule_raw: str, rule_type: TransformationRuleType | None) -> RDFPath: | |||
| rule_raw = urllib.parse.unquote(rule_raw) | |||
There was a problem hiding this comment.
Up for discussion how to deal with this. The old RDFPath is more restrictive than a URI, which I think might be a problem.
Should we reduce the RDFPath to the bare minimum, no hops allowed before v1 and instead reintrodure the more advanced concepts with an alpha flag?
There was a problem hiding this comment.
Fully agree, everything that is doing hops, etc. should be neat.prepare.instances....
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
nikokaoja
approved these changes
Feb 3, 2025
| @@ -327,6 +328,7 @@ def parse_table_lookup(raw: str) -> TableLookup: | |||
|
|
|||
|
|
|||
| def parse_rule(rule_raw: str, rule_type: TransformationRuleType | None) -> RDFPath: | |||
| rule_raw = urllib.parse.unquote(rule_raw) | |||
There was a problem hiding this comment.
Fully agree, everything that is doing hops, etc. should be neat.prepare.instances....
doctrino
force-pushed
the
standardize-naming
branch
from
5eeca19 to
42c35ec
Compare
doctrino
force-pushed
the
infer-handle-bad-names
branch
from
fa3e836 to
d3301a6
Compare
doctrino
force-pushed
the
infer-handle-bad-names
branch
from
d3301a6 to
74750af
Compare
# Conflicts: # cognite/neat/_utils/text.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.