Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instanceIds when creating a subscription #408

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

muradsater
Copy link
Contributor

No description provided.

@muradsater muradsater requested a review from a team as a code owner December 5, 2024 11:31
@ozangoktan ozangoktan requested a review from a team December 5, 2024 12:05
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@6985532). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pes/Beta/Subscriptions/SubscriptionDataResponse.cs 0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             master   #408   +/-   ##
=======================================
  Coverage          ?    62%           
=======================================
  Files             ?    357           
  Lines             ?   6946           
  Branches          ?    467           
=======================================
  Hits              ?   4245           
  Misses            ?   2449           
  Partials          ?    252           
Files with missing lines Coverage Δ
...Sdk.Types/Beta/Subscriptions/SubscriptionCreate.cs 100% <100%> (ø)
...Sdk.Types/Beta/Subscriptions/SubscriptionUpdate.cs 100% <100%> (ø)
...pes/Beta/Subscriptions/SubscriptionDataResponse.cs 82% <0%> (ø)

@muradsater muradsater merged commit f1e17a7 into master Dec 9, 2024
5 checks passed
@muradsater muradsater deleted the murads/subscriptions-instanceids branch December 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants