Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to Oryx v3 #236

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Refactor to Oryx v3 #236

merged 2 commits into from
Feb 26, 2021

Conversation

dbrattli
Copy link
Contributor

@dbrattli dbrattli commented Feb 25, 2021

Simplifies the generic types of HTTP handlers

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #236 (5143e15) into master (db40af4) will increase coverage by 1%.
The diff coverage is 70%.

@@          Coverage Diff          @@
##           master   #236   +/-   ##
=====================================
+ Coverage      53%    53%   +1%     
=====================================
  Files         162    162           
  Lines        2879   2893   +14     
  Branches      199    196    -3     
=====================================
+ Hits         1504   1519   +15     
+ Misses       1259   1258    -1     
  Partials      116    116           
Impacted Files Coverage Δ
CogniteSdk.Types/Common/ResponseError.cs 89% <ø> (ø)
Oryx.Cognite/src/3D.fs 53% <ø> (ø)
Oryx.Cognite/src/Assets.fs 100% <ø> (ø)
Oryx.Cognite/src/Beta/Handler.fs 0% <0%> (ø)
Oryx.Cognite/src/Beta/TemplateGroups.fs 0% <ø> (ø)
Oryx.Cognite/src/Common.fs 65% <ø> (ø)
Oryx.Cognite/src/Events.fs 100% <ø> (ø)
Oryx.Cognite/src/Playground/Functions.fs 0% <ø> (ø)
Oryx.Cognite/src/Playground/Handler.fs 0% <0%> (ø)
Oryx.Cognite/src/Raw.fs 82% <ø> (ø)
... and 27 more

Copy link
Contributor

@tengelskar tengelskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!

@dbrattli dbrattli merged commit 986b45c into master Feb 26, 2021
@dbrattli dbrattli deleted the feature/oryx-v3 branch February 26, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants