Steps towards a genome representation. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHANGED] these classes only encapsulate the sequences, so that now
indicated in the class names.
[CHANGED] this is an effort to be consistent with the cogent3 API,
but it needs to be checked thoroughly.
[NEW] this is a class that has only 2 methods and attributes for the species,
sequence db instance and the annotation db instance. This wrapping class
is required for memory efficiency because the cogent3 SequeceCollection
class is not designed for large sequence collections, either large sequences
or large numbers of sequences. The correct solution is to improve the cogent3
class performance. So this is an interim solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.