Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: seqcoll.to_fasta supports block_size #1822

Merged
merged 6 commits into from
Apr 27, 2024

Conversation

rmcar17
Copy link
Collaborator

@rmcar17 rmcar17 commented Apr 24, 2024

Addresses #1795

@rmcar17
Copy link
Collaborator Author

rmcar17 commented Apr 24, 2024

Looks like Python 3.9 is not supported by setup-python on macos-14 (actions/setup-python#850).
A result of the rollout to macos-14, may need to downgrade to macos-13 for now,

@ZeroIntensity
Copy link

macos-12 is what macos-latest used to point to, maybe it's a better idea to just use that.

@rmcar17
Copy link
Collaborator Author

rmcar17 commented Apr 26, 2024

Thanks Zero for your suggestion, think either one may have been good enough for our purposes. Looks like it's been resolved now anyways, so we'll be moving back to latest.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8843278136

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.724%

Totals Coverage Status
Change from base Build 8843240525: 0.003%
Covered Lines: 29669
Relevant Lines: 32346

💛 - Coveralls

Copy link
Collaborator

@GavinHuttley GavinHuttley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@GavinHuttley GavinHuttley merged commit 6d51668 into cogent3:develop Apr 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants