Implement full data source gRPC client and service #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements all data source gRPC service RPCs for the client and service. Adds a type check to ensure that the client implements the DataSource interface. Fixes: #59
jsnctl
reviewed
Dec 4, 2024
There was a problem hiding this comment.
All looking good (I'll defer approval until the upstream cofide-sdk-go changes are in as I've left a single comment on that)
From Slack discussion: we should probably think about deletion cases for each of the resources (this can even be deciding to not cover this case for the moment). I'll open a wider issue to track this across the various parts of the stack it'll apply
jsnctl
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all data source gRPC service RPCs for the client and service.
Adds a type check to ensure that the client implements the DataSource
interface.
Fixes: #59
Depends-On: cofide/cofide-api-sdk#9