Support per-plugin configuration #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful for CLI plugins.
This allows plugins to create a CommandContext without exporting the config package.
For some plugins it would be useful to be able to store configuration options in cofide.yaml. This change updates the plugin manager to support setting and retrieving per-plugin configuration keyed by the plugin name. The config can be set during Init or later using GetPluginConfig. A Struct protobuf message is used to allow for arbitrarily structured plugin config. Plugins can use the Struct directly or convert it to/from a more convenient native Go type. Fixes: #54 Depends-On: cofide/cofide-api-sdk#8
markgoddard
force-pushed
the
issues/54
branch
from
3b16cef to
9e2ab4a
Compare
jsnctl
approved these changes
Dec 2, 2024
nialdaly
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export command context package
It is useful for CLI plugins.
Move default CommandContext setup to NewCommandContext
This allows plugins to create a CommandContext without exporting the
config package.
Support per-plugin configuration
For some plugins it would be useful to be able to store configuration
options in cofide.yaml. This change updates the plugin manager to
support setting and retrieving per-plugin configuration keyed by the
plugin name. The config can be set during Init or later using
GetPluginConfig.
A Struct protobuf message is used to allow for arbitrarily structured
plugin config. Plugins can use the Struct directly or convert it to/from
a more convenient native Go type.
Fixes: #54
Depends-On: cofide/cofide-api-sdk#8