Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete original package directory #31

Merged
merged 3 commits into from
Dec 23, 2019
Merged

Delete original package directory #31

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34e4014
Remove packages from the vendor dir after they are moved
coenjacobs Dec 23, 2019
dc14cba
Deleting directories needs to happen on a relative path
coenjacobs Dec 23, 2019
ef690d6
Refactor delete original directories into seperate method
coenjacobs Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Mover.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ public function movePackage(Package $package)

$this->movedPackages[] = $package->config->name;
}

$this->deletePackageVendorDirectories();
}

/**
Expand Down Expand Up @@ -125,4 +127,17 @@ public function moveFile(Package $package, $autoloader, $file, $path = '')

return $targetFile;
}

/**
* Deletes all the packages that are moved from the /vendor/ directory to
* prevent packages that are prefixed/namespaced from being used or
* influencing the output of the code. They just need to be gone.
*/
protected function deletePackageVendorDirectories()
{
foreach ($this->movedPackages as $movedPackage) {
$packageDir = '/vendor/' . $movedPackage;
$this->filesystem->deleteDir($packageDir);
}
}
}