Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when everything matches. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ccarouge
Copy link
Member

Instead of having no output when everything matches, this will tell users what is going on.

@ccarouge
Copy link
Member Author

Actually I haven't checked the tests and whether there is one where everything matches.

@aidanheerdegen
Copy link
Member

Because of the dependence on mdss only half the tests are run on travis.

Have you run pytest locally?

Also I don't know if all the possible paths through that logic are tested, and it has been rearranged quite extensively. I'll need to take time to check it thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants