fix: Drop karma as a peerDependency. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For discussion and reasoning see karma-runner/integration-tests#5.
|
@sokra ping |
sokra
added a commit
that referenced
this pull request
Jul 14, 2015
fix: Drop karma as a peerDependency.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to drop
karmaas a peer dependency, as there a lot of issues when trying to use release candidate versions. I'm now in the middle of making the needed PRs to do this, would be great to see this merged, as that means people can actually use versions like the current canary0.13.0-rc.4with the plugin.For more discussion and reasoning see karma-runner/integration-tests#5.