-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(karma-webpack): Override output.filename
with '[name].js'
#381
Conversation
@thijstriemstra: this pull request should fix your issue |
thanks for the ping @matthieu-foucault, can i install and test this PR using npm? |
Yes, using |
works: "[email protected]" thanks @matthieu-foucault |
output.filename
with '[name].js'
@matthieu-foucault can this be released as a new RC? |
@thijstriemstra Done! Sorry for the delay |
thanks. for some reason it doesn't allow me to install rc.6
And |
It does appear in npmjs though (under the
|
This PR contains a:
Motivation / Use-Case
If there are multiple tests, and the webpack configuration has a static
output.filename
, e.g.'bundle.js'
, all entry points will be emitted to the same bundle. Karma will output errors, andkarma-webpack
will ultimately fail as test files will not have any corresponding output file.