Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't swallow configuration errors #232

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Conversation

joshwiens
Copy link
Contributor

@joshwiens joshwiens commented Mar 11, 2017

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Configuration / Schema errors from ajv are swallowed by karma-webpack making debugging difficult.

What is the new behavior?

Options is wrapped in a try / catch & throws a stack & or details

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

Other information:

@joshwiens joshwiens force-pushed the d3viant0ne-OptionsErrors branch from 228bb52 to b7cdd91 Compare March 11, 2017 05:23
@joshwiens joshwiens added this to the 2.0.3 milestone Mar 11, 2017
@joshwiens joshwiens self-assigned this Mar 11, 2017
@joshwiens joshwiens merged commit 4216f13 into v2 Mar 15, 2017
@joshwiens joshwiens deleted the d3viant0ne-OptionsErrors branch March 15, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants