Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention unsupported plugins #184

Closed
wants to merge 7 commits into from

Conversation

fraziermork
Copy link

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • [X ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [X ] Other... Please describe: Note added to readme.

What is the current behavior? (You can also link to an open issue here)
Readme does not mention existence of unsupported plugins, see issue #149

What is the new behavior?
Describe which plugins are incompatible

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

Add note of which plugins are unsupported based on issue #149

Lior Amsalem and others added 7 commits October 11, 2016 19:32
@jsf-clabot
Copy link

jsf-clabot commented Dec 8, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

✅ MikaAK
❌ lior-a
❌ eazy-g
❌ DanielaValero
❌ fraziermork

@joshwiens
Copy link
Contributor

@fraziermork - #master is currently being rewritten ( completely ) with the intent of increasing performance and karma-webpack not suffering some the the short comings it does today with the rest of the webpack ecosystem.

Point being, this should really target the v1 branch where this documentation is applicable.

@fraziermork fraziermork changed the base branch from master to v1 December 8, 2016 15:27
@fraziermork
Copy link
Author

@d3viant0ne Is it enough to just change the base branch, or should I close this pull request and make a new one to that branch?

@joshwiens
Copy link
Contributor

You're good with just changing the base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants