Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Unit & Integration Test Tools #156

Merged
merged 1 commit into from
Jul 31, 2016
Merged

chore(test): Unit & Integration Test Tools #156

merged 1 commit into from
Jul 31, 2016

Conversation

joshwiens
Copy link
Contributor

@joshwiens joshwiens commented Jul 31, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
A gigantic void where our unit tests should be. :(

What is the new behavior?
Adds the base layout & libs to allow multiple parties to author consistent tests.

Note the branch target is unit-testing and not master

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: Karma support limited to version 1.x or higher
  • Migration path for existing applications: customContextFile & customDebugFile format must be updated to 1.x format.
  • Github Issue(s) this is regarding: Travis execution inline with webpack/webpack #140

Other information:

  • Adds Babel and supporting libs
  • Introduces AVA for unit test execution
  • Introduces NYC for coverage generation
  • Adds Mocha for karma/mocha integration tests
  • Adds cross-env for setting ENV cross platform.
  • Increments versions on all Karma devDependencies.
  • Adds tap-spec for cleaner unit test output.
  • Adds npm scripts for execution of the above.
  • Updates eslintrc to something sane.
    • 'single quotes' currently set to warning not error.
    • Updates style based on eslintrc.
  • Adds Babel & AVA Configs
    • Babel should be moved to an .rc on full es6 implementation.

esLint List ( Set to error from warning on Babel build PR )

  • prefer-spread
  • prefer-template
  • object-shorthand
  • func-style

@MikaAK
Copy link
Contributor

MikaAK commented Jul 31, 2016

I'll merge this by hand and add in my own eslintrc overtop with all the es6 build changes!

@joshwiens
Copy link
Contributor Author

@MikaAK - Giving you write access to my fork now, far easier than doing it manually :)

  - Adds Babel and supporting libs
  - Adds Mocha for karma/mocha integration tests
  - Adds cross-env for setting ENV cross platform.
  - Increments versions on all Karma devDependencies.
  - Adds npm scripts for execution of the above.
  - Updates eslintrc to something sane
    - Updates style based on eslintrc.

chore(ci): Adds base travis.yml

Update .eslintrc

fix(style): Updates with final eslint rules
@MikaAK MikaAK merged commit be1499d into codymikol:unit-testing Jul 31, 2016
@joshwiens joshwiens deleted the d3viant0ne-UnitTestInfra branch July 31, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants