Fix Lint errors in examples and eslint path #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "pretest": "npm run lint && npm run beautify-lint", | |||
| "lint": "eslint lib", | |||
| "lint": "eslint .", | |||
There was a problem hiding this comment.
This should really be explicit "lint": "eslint example index.js mocha-env-loader.js",
Targeting the project root opens up the possibility of linting something we don't want to. I say that recognizing this is knit picky and you are fixing my copy paste fail (thanks).
There was a problem hiding this comment.
@d3viant0ne ok Ill adjust it, I was actually thinking the same thing 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lint errors in examples and change eslint path. Related to work done in #143
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
$ npm run lintwill lint./libeslint lib- lib does not existWhat is the new behavior?
eslint .- lint currentDoes this PR introduce a breaking change?