Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still using old version of webpack-dev-middleware that doesn't support webpack 3.x #268

Closed
hexpunk opened this issue Oct 13, 2017 · 5 comments

Comments

@hexpunk
Copy link
Contributor

hexpunk commented Oct 13, 2017

I'm submitting a bug report

Webpack version:
3.7.1

Webpack Karma version:
2.0.5

Karma version:
1.7.1

Please tell us about your environment:
OSX 10.12.6 (16G29)

Current behavior:
Installing karma-webpack warns with:

warning "[email protected]" has incorrect peer dependency "webpack@1 || ^2.1.0-beta || ^2.2.0-rc.0".

Expected/desired behavior:
webpack-dev-middleware is already at version 1.12.0. We should probably upgrade to that. It includes webpack 3.x as a peer dependency.

@michael-ciniawsky
Copy link
Contributor

"webpack-dev-middleware": "^1.0.11" the dependency uses the ^ semver range (minor/patch), so npm update should pull a newer version if available, maybe you need to clean your npm cache beforehand. Feel free to send a PR updating the minimum to ^1.2.0

@hexpunk
Copy link
Contributor Author

hexpunk commented Oct 14, 2017

You're right. I should be picking up 1.2.0 in that case. I'm using Yarn. Maybe it's doing something weird. In any case, I'll send a PR your way.

@joshwiens
Copy link
Contributor

@jayandcatchfire - Older version stuck in a lock file? Also, what version of Yarn

@hexpunk
Copy link
Contributor Author

hexpunk commented Oct 16, 2017

@d3viant0ne It very well could be a lock file issue. The yarn version is either 1.2.0 or 1.2.1. (It was my work machine and I don't have it handy at the moment.)

@alexevanczuk
Copy link

@jayandcatchfire
I had the same problem, and I did have an older version stuck in the lock file. I removed my lock file and reinstalled and it installed the newest version of webpack-dev-middleware.

joshwiens pushed a commit that referenced this issue Oct 20, 2017
Update version of webpack-dev-middleware pursuant to #268
@michael-ciniawsky michael-ciniawsky removed this from the 2.0.7 milestone Nov 11, 2017
mattlewis92 pushed a commit that referenced this issue Dec 14, 2017
Update version of webpack-dev-middleware pursuant to #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants