Force $binaryPrefixes array ordering on 32-bit systems, fixes #83 #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when a 32-bit system breaks associative array ordering when dropping keys over 2^32-1 in
String\BinarySuffix
andString\MetricSuffix
As noted by @mikaelcom, the following array:
in
String\BinarySuffix
becomes:during runtime on 32-bit systems. This breaks the conversion logic, causing a
Division by zero
exception.The introduced change sorts the associative array with
krsort()
so that it gets ordered properly:Tested on: Ubuntu 14.04.5, kernel 4.4.0-42-generic i686, PHP 5.5.9-1ubuntu4.20.
Should be tested on other architectures and with other values, but I don't think there are any negative consequences to this change.