[WIP] Introduce time difference humanizer #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @return int | ||
| */ | ||
| public function getThresholdQuantity(); |
There was a problem hiding this comment.
Looks great, but my only concern is that getThresholdQuantity is not consistent. Cuz it can return hours, seconds, days. I think it would be good idea to make it consistent. Perhaps removing getMiliseconds and make getThreasholdQuanity return those miliseconds itself.
There was a problem hiding this comment.
Agree, I dont like it neither. I will try to get rid of it.
|
@defrag updated ;) |
defrag
added a commit
that referenced
this pull request
Apr 28, 2014
[WIP] Introduce time difference humanizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add more tests and translations