Add Spanish translation. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orestes uhm could you please show me some examples? I mean how sentence should be build to make it works with Spanish. Maybe there is some way to update https://github.com/coduo/php-humanizer/blob/master/src/Coduo/PHPHumanizer/DateTime/PreciseFormatter.php to handle such cases. |
|
Alright. |
Closed
|
@norzechowicz all done. |
|
@orestes please also update tests in https://github.com/coduo/php-humanizer/blob/master/tests/Coduo/PHPHumanizer/Tests/DateTimeTest.php |
|
@orestes thanks, could you please rebase your branch against master? After that I gonna merge it |
added 6 commits
November 6, 2015 15:20
orestes
force-pushed
the
es-translation
branch
from
67435b7 to
5260e91
Compare
|
Rebased and pushed :) |
|
@orestes awesome! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on a Spanish translation. There might be a problem with the way you generate the compound past/future in PreciseFormatter, which is always a suffix. In Spanish, we actually use a prefix. When I figure out a way of implementing it I'll send in another pull request.