Oxford collection + phpcs fixer cleanup. #22
Conversation
| 'comma_separated', | ||
| array("%list%" => 'Michal, Norbert', '%last%' => "Lukasz"), | ||
| 'oxford' | ||
| )->willReturn('Michal, Norbert and Lukasz'); |
There was a problem hiding this comment.
Ur right, but some ppl in different communites always asked for ability to specify if you need comma or not, so the format is defined in translation file. In that case everyone can adjust this to their own locale. Tho maybe I should add the default comma in translation file.
Updating comma Updating readme
defrag
force-pushed
the
feature/oxford
branch
from
9aae131 to
9eee3f5
Compare
Oxford collection + phpcs fixer cleanup.
| @@ -0,0 +1,3 @@ | |||
| only_two: "%first% and %second%" | |||
| comma_separated: "%list%, and %last%" | |||
| comma_separated_with_limit: "{1} %list%, and 1 other|[2,Inf] %list%, and %count% others" | |||
There was a problem hiding this comment.
@orestes @lightglitch @dagaa @Forst @sarelvdwalt @ozmodiar @mattallty @cnkt @tbreuss @IgorDePaula @omissis - anyone willing to help us here with translations?
There was a problem hiding this comment.
Will do :) This one seems pretty straightforward, no caveats as in difference.xx.yaml
I could of course point out that many languages have gender-depending noun forms and in this case it affects "1 other", but this can be worked around.
There was a problem hiding this comment.
Sure. No problem with Spanish, Galician or Catalan.
There was a problem hiding this comment.
I've just sent in the PR containing the italian translation.
No description provided.