Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for Portuguese - Brazil #10

Merged
merged 1 commit into from
Oct 26, 2015

Conversation

IgorDePaula
Copy link
Contributor

Add translation for Portuguese - Brazil

.idea
nbproject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two lines should be removed becuase we can't support all IDEs. You can add those lines into your globla .gitignore.
https://help.github.com/articles/ignoring-files/

@norberttech
Copy link
Member

@IgorDePaula thanks for your work! Could you also look at https://github.com/coduo/php-humanizer/blob/master/spec/Coduo/PHPHumanizer/DateTimeSpec.php#L103 spec and add similar example for Portuguese - Brazil language?

@norberttech norberttech merged commit 17818b2 into coduo:master Oct 26, 2015
@lightglitch
Copy link
Contributor

@norzechowicz this file can also be used for Portuguese from Portugal.

@norberttech
Copy link
Member

@lightglitch Portuguese from Portugal should be stored in file difference.pt.yml - there might be no difference in current translations but we can't exclude such possibility in the future.

@lightglitch
Copy link
Contributor

@norzechowicz What I'm saying is that you can copy and use this file as difference.pt.yml because now there is no difference. I was thinking that making a pull request with a copy of the file was unnecessary.

@norberttech
Copy link
Member

PR is more then welcome even if file is just a copy of pt_PT.yml file :) Thanks for reporing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants