Sql connections #113
Merged
Sql connections #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating my fork to the current version of codonPython.
Adding the intial file.
Adding commonly used SQL_connections.py
starting test_SQL_connections.py
Pytest script for SQL_connections
changing test_SQL_connections.py to SQL_connections_test.py
Improved the descriptions and tidied up the functions.
Adding SQL_connections module import!
Created initial file
made first test: test_ref_decode_col_num
Cleaned up the unit test.
Added connections to each function to allow repointing of functions by users.
Added org_col unit tests.
|
Hey @Naawww Can you please check the pipeline tasks that have failed and rectify them? |
murd0
reviewed
Jan 13, 2020
murd0
reviewed
Jan 13, 2020
murd0
suggested changes
Jan 13, 2020
…13/files/accda9cce9f2dfe6b6433d1fe090ad40f7140bae - removed unused import from codonPython.SQL_connections - removed unused "sql" variable and definition
|
To fix pyodbc install error for the pipeline: |
To fix travis being unable to install pyodbc requirement
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
========================================
Coverage ? 87.7%
========================================
Files ? 26
Lines ? 553
Branches ? 0
========================================
Hits ? 485
Misses ? 68
Partials ? 0
Continue to review full report at Codecov.
|
murd0
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another simple module. Contains wrapped reference data library connections. These will not be accessible to those outside the organisation though, so is this a problem?