Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial implement of the gRPC middleware - logrus, prometheus #44

Merged
merged 8 commits into from
Jun 3, 2021
Merged

feat: initial implement of the gRPC middleware - logrus, prometheus #44

merged 8 commits into from
Jun 3, 2021

Conversation

nicewook
Copy link
Contributor

@nicewook nicewook commented Jun 2, 2021

No description provided.

@nicewook
feat: initial implement of the gRPC middleware - logrus, prometheus
5b2a3ef 
1. logrus: request GetHello() then logrus middleware logs gRPC
   information
2. prometheus: browse :9092/metrics works
@nicewook nicewook requested a review from kkweon June 2, 2021 06:34
kkweon
kkweon requested changes Jun 2, 2021
View reviewed changes
Copy link
Member

@kkweon kkweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음번엔는 기능 단위 PR (prom따로 logging 따로) 부탁드립니다.

.vscode/settings.json Outdated Show resolved Hide resolved
server/cmd/server/main.go Outdated Show resolved Hide resolved
server/cmd/server/main.go Outdated Show resolved Hide resolved
nicewook
nicewook commented Jun 2, 2021
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
kkweon
kkweon approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@kkweon kkweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@kkweon
Copy link
Member

kkweon commented Jun 2, 2021

도움이 필요하신가요?

@nicewook
Copy link
Contributor Author

nicewook commented Jun 3, 2021

그냥 머지하면 되려나요?

  1. 어제는 그 순간에 resolve가 안된다고 팝업이 떴었습니다
  2. server/go.sum conflict가 난다고 하는데 그냥 머지해도 되려나요?

@nicewook nicewook enabled auto-merge June 3, 2021 01:34
@kkweon
Copy link
Member

kkweon commented Jun 3, 2021

아니요 수정하셔야 됨니당 껄껄껄

@kkweon
Copy link
Member

kkweon commented Jun 3, 2021 •
edited
Loading

대신 해드릴수도 있으니까 필요하시면 말씀하세요

대신 해드렸습니다.

golangci-lint run --fix

@kkweon kkweon disabled auto-merge June 3, 2021 03:07
@kkweon kkweon enabled auto-merge (squash) June 3, 2021 03:07
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #44 (84e8e22) into main (a003fb0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #44   +/-   ##
=====================================
  Coverage   7.54%   7.54%           
=====================================
  Files          2       2           
  Lines         53      53           
=====================================
  Hits           4       4           
  Misses        48      48           
  Partials       1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72817ed...84e8e22. Read the comment docs.

@kkweon kkweon merged commit f047b82 into main Jun 3, 2021
@kkweon kkweon deleted the f/grpc-middleware branch June 3, 2021 03:11
@nicewook
Copy link
Contributor Author

nicewook commented Jun 3, 2021

감사합니다

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkweon kkweon kkweon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicewook @kkweon