Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VideosResponseFromDB :: Database -> GetVideosResponse #111

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

kkweon
Copy link
Member

@kkweon kkweon commented Jun 23, 2021

Closes #108

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #111 (4a28db0) into main (adfeef3) will increase coverage by 4.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   79.06%   83.63%   +4.56%     
==========================================
  Files           4        5       +1     
  Lines          86      110      +24     
==========================================
+ Hits           68       92      +24     
  Misses         17       17              
  Partials        1        1              
Impacted Files Coverage Δ
server/pkg/handlers/handlers.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfeef3...4a28db0. Read the comment docs.

Copy link
Contributor

@nicewook nicewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicewook
Copy link
Contributor

#108 이 이걸 이용해서 response 하도록 하는 것이지요?

Copy link
Contributor

@nicewook nicewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 했어야 하는 부분인데 이렇게 정리주시니 감사하네요.
보면서 배웁니다

@nicewook nicewook merged commit 64b7a86 into main Jun 23, 2021
@nicewook nicewook deleted the feat-getvideosresponse branch June 23, 2021 07:10
@github-actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement f :: Database -> GetVideosResponse
2 participants