Add _block:_ and _blocker_ features as per #52 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit of a delay here, but planning to review this in conjunction with #60 on Monday. |
|
Looking to go with #60 on this one as discussed on slack. There's some differences that make it more favorable, and I prefer to go a bit more thread safe (even if it requires a harder to maintain code base). I appreciate all of the work you've done here, and I'm very happy to transfer you the $300 bounty as well. Just message me a paypal address over slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm well aware that a PR already exists for this. However, I'd like to bring to light a different approach using arrays: splitting commands into arrays, and treating every array as a separate sequence of threads. In this solution, a
_block:_instruction essentially turns each command into its own array.