Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isASocialNetworkUrl() regex for summarize-cool-pages #44

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix: isASocialNetworkUrl() regex for summarize-cool-pages #44

merged 3 commits into from
Aug 30, 2023

Conversation

djang0dev
Copy link
Contributor

  • Refactor the old regex that does not fire to check if it's a social network URL
  • Add test for isASocialNetworkUrl(), and for isPageSummarizeSuccessData() guard (maybe to much)

@neolectron neolectron merged commit ef17bbe into codinglab-io:master Aug 30, 2023
potb pushed a commit that referenced this pull request Jan 5, 2024
@djang0dev @potb
fix: isASocialNetworkUrl() regex for summarize-cool-pages (#44)
2049cfb
potb pushed a commit that referenced this pull request Jan 5, 2024
@djang0dev @potb
fix: isASocialNetworkUrl() regex for summarize-cool-pages (#44)
4dbf3af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolectron neolectron neolectron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djang0dev @neolectron