Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to set minHeight 0px #987

Merged
merged 9 commits into from
Dec 7, 2019
Merged

Fix to set minHeight 0px #987

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ac93017
Release 2.16 (#966)
neSpecc Nov 30, 2019
cee5f83
Fix changeling list items (#975)
neSpecc Nov 30, 2019
3382da1
Update changelog (#976)
gohabereg Nov 30, 2019
6fccd70
Fix to set minHeight 0px
hata6502 Dec 7, 2019
5c4590c
Merge branch 'release/2.16' into pr/987
neSpecc Dec 7, 2019
e786278
upd version
neSpecc Dec 7, 2019
1e9f93d
Update CHANGELOG.md
neSpecc Dec 7, 2019
88f78a1
Merge branch 'release/2.16' into pr/987
neSpecc Dec 7, 2019
ab1f24f
upd bundle
neSpecc Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/editor.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
### 2.16.1

- `Fix` — Fix Firefox bug with incorrect height and cursor position of empty content editable elements [#947](https://github.com/codex-team/editor.js/issues/947) [#876](https://github.com/codex-team/editor.js/issues/876) [#608](https://github.com/codex-team/editor.js/issues/608) [#876](https://github.com/codex-team/editor.js/issues/876)
- `Fix` - Set initial hidden Inline Toolbar position [#979](https://github.com/codex-team/editor.js/issues/979)
- `Fix` - Set initial hidden Inline Toolbar position [#979](https://github.com/codex-team/editor.js/issues/979)
- `Fix` - Fix `minHeight` option with zero-value issue [#724](https://github.com/codex-team/editor.js/issues/724)

### 2.16

Expand Down
2 changes: 1 addition & 1 deletion src/components/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export default class Core {
* Height of Editor's bottom area that allows to set focus on the last Block
* @type {number}
*/
this.config.minHeight = this.config.minHeight || 300;
this.config.minHeight = this.config.minHeight !== undefined ? this.config.minHeight : 300 ;

/**
* Initial block type
Expand Down