issue-715: insert method in blocks API #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleoxhindoli
requested review from
gohabereg,
khaydarov,
neSpecc and
talyguryn
as code owners
gohabereg
reviewed
May 1, 2019
| @@ -26,6 +26,12 @@ export default class BlocksAPI extends Module { | |||
| getBlocksCount: () => this.getBlocksCount(), | |||
| stretchBlock: (index: number, status: boolean = true) => this.stretchBlock(index, status), | |||
| insertNewBlock: () => this.insertNewBlock(), | |||
| insert: ( | |||
| index: number, | |||
There was a problem hiding this comment.
Maybe make index optional and insert new block at the current position?
|
Hi @kleoxhindoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
insertAtmethod in theblockManager. Same asinsertbut accepts an index param as wellinsertto useinsertAtto avoid code duplicationinsertAtmethod to the public API, via theeditor.blocks.insertmethod, to allow insertion of any blocks programmatically at any indexSolves #715
First PR, feedback is welcomed