Create a new block when clicked at the bottom #1605
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? I would like to update editorjs higher than |
gohabereg
requested changes
Apr 7, 2021
src/components/modules/ui.ts
Outdated
| * to prevent unnecessary tree-walking on Tools with many nodes (for ex. Table) | ||
| * - Or, default-block is not empty | ||
| */ | ||
| if (!Tools.isDefault(BlockManager.lastBlock.tool) || !BlockManager.lastBlock.isEmpty) { |
There was a problem hiding this comment.
Please pull next branch and use BlockManager.lastBlock.tool.isDefault
There was a problem hiding this comment.
Fixed for version 2.20.0! 🎉
hata6502
force-pushed
the
bugfix/fix-clicking-at-the-bottom
branch
from
cfdd9db to
9da520e
Compare
gohabereg
approved these changes
Apr 8, 2021
neSpecc
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1588