Resolve editor.destroy() Problem #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robonetphy
requested review from
gohabereg,
khaydarov and
neSpecc
as code owners
sis-dk
reviewed
Oct 29, 2020
| @@ -381,8 +381,6 @@ export default class Toolbar extends Module<ToolbarNodes> { | |||
| * It is used in Read-Only mode | |||
| */ | |||
| private destroy(): void { | |||
| this.Editor.Toolbox.destroy(); | |||
There was a problem hiding this comment.
This destroy is also called when we toggle read only mode. Would that expect this destroy to take care of destroying toolbox and blockSettings? Just curious as we use this in production.
There was a problem hiding this comment.
@sis-dk
Ya that would be handle with toggle button. We just removing this because it called twice when we trying to destroy the editor.
There was a problem hiding this comment.
@sis-dk @robonetphy thanks. I've moved the Toolbox and BlockSettinga destroy methods to the toggleReadOnly, because it is the logical opposite to this.drawUI().
- On the read-only mode toggling all the modules destroys correctly, no memory leak here.
- On
editor.destroy()all modules` destroy fired once.
neSpecc
approved these changes
Nov 5, 2020
gohabereg
approved these changes
Nov 6, 2020
neSpecc
added a commit
that referenced
this pull request
Dec 8, 2020
* Resolve editor.destroy() Problem * Resolve this.flipper undefined in inline.ts in readonly mode * fix destroy methods * destroy conversion toolbar on toggling read-only Co-authored-by: Peter Savchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1380
@neSpecc let me know Changes I have to make in CHANGELOG.md (Create new version or new patch) ?
and Also,
yarn lintgiving me as the following warning,How to solve that?