Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redactor capturing click events #1240

Closed
wants to merge 7 commits into from
Closed

Conversation

elis
Copy link

@elis elis commented Jul 19, 2020

redactor was used to capture click events for adding a new block - I've added a redactorClicker element just after the original redactor and bound the redactorClicked event to the redactorClicker element instead of redactor.

Related issues: #1051 , #946

@gohabereg gohabereg changed the base branch from master to next July 26, 2020 15:48
@gohabereg
Copy link
Member

Hi @elis, @natterstefan, @2277Dhruv
This fix won't work for the current version as we use the same click event to open external links (with Ctrl pressed).

I've made another one in #1252, can you try it for your use cases

@gohabereg
Copy link
Member

#1252 seems to work, so I'm closing this PR

@gohabereg gohabereg closed this Aug 26, 2020
@elis
Copy link
Author

elis commented Sep 25, 2020

@gohabereg Great! just checked it and it works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants