Fix block deleted when settings are opened #1090

[alcarazzam]

Prevent block removal when settings are opened #1090

[neSpecc]

I think it would better to leave an ability to delete blocks this way. So it's better to close Block Settings in such a case.

[alcarazzam]

I think it would better to leave an ability to delete blocks this way. So it's better to close Block Settings in such a case.

But there's a problem with input elements inside settings. If you press the backspace key while editing text in a settings' input, the block is deleted instead of doing the default behavior (remove a character).

[neSpecc]

I think it would better to leave an ability to delete blocks this way. So it's better to close Block Settings in such a case.

But there's a problem with input elements inside settings. If you press the backspace key while editing text in a settings' input, the block is deleted instead of doing the default behavior (remove a character).

Ok, got that. We need to think about how to detect if the Caret placed inside some kind of an editable element at the settings. Or maybe allow an ability to prevent default behavior from the plugin side.

[gohabereg]

I think we can use document.activeElement for that

[alcarazzam]

Thanks @neSpecc and @gohabereg for the suggestions. I'l try to implement the check if we're in an editable element tomorrow.

[alcarazzam]

PR updated.

[neSpecc]

we have a useful method for that, see dom.canSetCaret()

[alcarazzam]

Ok, thanks. It has more features. I'll update the PR this evening if I have time.

[neSpecc]

The solution works, but it only allows to press backspace at the input. There are also some problems with Flipper - class responsible for tab/arrow navigation between buttons:

• you can't navigate by arrows inside the input at the block tunes
• you can't focus the input with Flipper
• the input has no auto focus when block tunes are opened

[alcarazzam]

Closing in favor of #1123