Add Gemfile.lock parsing for dependency parser #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Bundler gem for parsing, parses only name for now, we should probably extract URL for repos.
khasinski
force-pushed
the
dependency-parsing-ruby
branch
from
2c0e323 to
8cb3145
Compare
schneems
requested changes
Oct 6, 2022
| def fetch_spec(name:, version: nil) | ||
| full_spec = fetcher.fetch_spec([name, version]) | ||
| { name: full_spec.name, url: extract_url(full_spec), description: full_spec.description } | ||
| rescue |
There was a problem hiding this comment.
Was there a class of error that triggered this specific rescue? I'm just curious. The other rescue looks like a "passed in the wrong file" kind of thing. I feel like we should capture this error too, but I'm not entirely sure what the failure modes that would trigger the rescue here are.
There was a problem hiding this comment.
I haven't found any. I can remove it, but it seems like it's better to log the failed spec instead of failing the entire file, we can at least get some log from it.
|
Any updates? This was pretty close to over the line. |
|
Hey, I'll finish it up today |
khasinski
force-pushed
the
dependency-parsing-ruby
branch
from
457706d to
6497be9
Compare
khasinski
force-pushed
the
dependency-parsing-ruby
branch
from
6497be9 to
f728e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency parsing for #1686
Uses Bundler gem for parsing, parses only name for now, we should probably extract URL for repos.
Description
Related Issue
Motivation and Context
An initial stub to get the dependency parsing running
How Has This Been Tested?
Checklist: