Add option to disable initial get request #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firing an get here is bad style. If you just want to set an option, there is no need to get it. Because it's a breaking change, I just added an option. Please consider changing this default behaviour in the next major release.
|
I'm not sure it's "bad style", but does have potential to interfere with synchronous-style usage as you pointed out. I updated the documentation and it looks good to me. |
codetheweb
approved these changes
Nov 28, 2020
|
Published in v6.1.0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firing an get here is bad style. If you just want to set an option, there is no need to get it.
Because it's a breaking change, I just added an option. Please consider changing this default behaviour in the next major release.