Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement login / logout through GitHub #90

Merged
merged 2 commits into from
Jul 24, 2019
Merged

feat: implement login / logout through GitHub #90

merged 2 commits into from
Jul 24, 2019

Conversation

marianzburlea
Copy link
Member

this fixes #89

QuintyHH
QuintyHH approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@QuintyHH QuintyHH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pavelciupitu
Copy link
Contributor

it's OK !!

@marianzburlea marianzburlea self-assigned this Jul 24, 2019
@marianzburlea
Copy link
Member Author

it's OK !!

THanks a lot!

pavelciupitu
pavelciupitu approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@pavelciupitu pavelciupitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !!

psyhedeliq
psyhedeliq approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@psyhedeliq psyhedeliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

pavelciupitu
pavelciupitu approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@pavelciupitu pavelciupitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok..

tandaraelena
tandaraelena approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@tandaraelena tandaraelena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

pavelciupitu
pavelciupitu approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@pavelciupitu pavelciupitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok again!

@marianzburlea marianzburlea merged commit 55d084d into dev Jul 24, 2019
@marianzburlea marianzburlea deleted the feat/implement-login-logout-through-gitHub-89 branch July 24, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyhedeliq psyhedeliq psyhedeliq approved these changes

@pavelciupitu pavelciupitu pavelciupitu approved these changes

@QuintyHH QuintyHH QuintyHH approved these changes

@tandaraelena tandaraelena tandaraelena approved these changes

Assignees

@marianzburlea marianzburlea

Labels
None yet
Projects
None yet
Milestone
Create and display courses
Development

Successfully merging this pull request may close these issues.

feat: implement login / logout through GitHub
5 participants
@marianzburlea @pavelciupitu @psyhedeliq @QuintyHH @tandaraelena