-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cancelability from the dictionary #1942
Remove cancelability from the dictionary #1942
Conversation
@enjoy-binbin just because it's used in a real, large (and old) project doesn't mean necessarily that it's not a misspelling. For example, the V8 JavaScript engine (which powers Google Chrome and Node.js) has several C++ types defined which have |
I am not really sure about that. So i am going to get outside help... Pinging... @yoav-steinberg |
I think you're right actually @enjoy-binbin: https://en.wiktionary.org/wiki/cancellability (lists https://en.wiktionary.org/wiki/cancelability as an alternate spelling). |
It would be nice to see it in a commercial dictionary which probably spends more time and effort vetting it's entries. I wonder if it should be rare rather than dropped entirely? |
@enjoy-binbin will you please remove it from |
@bl-ue Sure. Already updated. Please check again for me. |
And add it to dictionary_rare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
cancelability and cancellability both are correct spellings.
Remove it from the dictionary
And add it to dictionary_rare.
We can see many uses here: https://linux.die.net/man/3/pthread_setcanceltype