Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cancelability from the dictionary #1942

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Remove cancelability from the dictionary #1942

merged 1 commit into from
Jun 13, 2021

Conversation

enjoy-binbin
Copy link
Contributor

@enjoy-binbin enjoy-binbin commented Jun 10, 2021

cancelability and cancellability both are correct spellings.

Remove it from the dictionary
And add it to dictionary_rare.

We can see many uses here: https://linux.die.net/man/3/pthread_setcanceltype

@bl-ue
Copy link
Contributor

bl-ue commented Jun 10, 2021

@enjoy-binbin just because it's used in a real, large (and old) project doesn't mean necessarily that it's not a misspelling. For example, the V8 JavaScript engine (which powers Google Chrome and Node.js) has several C++ types defined which have Convertable in their names, which is a misspelling. The correct spelling is Convertible. https://github.com/v8/v8/search?q=convertable

@enjoy-binbin
Copy link
Contributor Author

I am not really sure about that. So i am going to get outside help...

Pinging... @yoav-steinberg

@bl-ue
Copy link
Contributor

bl-ue commented Jun 11, 2021

I think you're right actually @enjoy-binbin: https://en.wiktionary.org/wiki/cancellability (lists https://en.wiktionary.org/wiki/cancelability as an alternate spelling).

@bl-ue bl-ue requested a review from peternewman June 11, 2021 11:27
@bl-ue bl-ue added the dictionary Changes to the dictionary label Jun 11, 2021
@peternewman
Copy link
Collaborator

I think you're right actually @enjoy-binbin: https://en.wiktionary.org/wiki/cancellability (lists https://en.wiktionary.org/wiki/cancelability as an alternate spelling).

It would be nice to see it in a commercial dictionary which probably spends more time and effort vetting it's entries.

I wonder if it should be rare rather than dropped entirely?

@bl-ue
Copy link
Contributor

bl-ue commented Jun 11, 2021

@enjoy-binbin will you please remove it from dictionary.txt and add it instead to https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_rare.txt?

@enjoy-binbin
Copy link
Contributor Author

@bl-ue Sure. Already updated. Please check again for me.
ps sorry for the delay

And add it to dictionary_rare.
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bl-ue bl-ue merged commit 6957e2c into codespell-project:master Jun 13, 2021
@enjoy-binbin enjoy-binbin deleted the remove_cancelability branch June 13, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants