Add --ignore-regex #1592
Merged
Add --ignore-regex #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for issue #676, where typos are found in actually-okay URIs/emails. Because these are closer to names in context, this ignores them. Mechanically, this erases the URI/email text before the word regex is applied.
jonmeow
changed the title
peternewman
requested changes
Jul 27, 2020
peternewman
requested changes
Aug 10, 2020
codespell_lib/_codespell.py
Outdated
| help='regular expression which is used to find ' | ||
| 'patterns to ignore by treating as whitespace. ' | ||
| 'When writing regexes, consider ensuring there ' | ||
| 'is boundary non-word chars, e.g., ' |
There was a problem hiding this comment.
Nit sorry, grammar wise it should be "ensuring there are boundary..."
|
@larsoner do you want to review this, or are you happy with mine? |
larsoner
approved these changes
Aug 10, 2020
peternewman
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally for issue #676, but the preference there is for a different approach. We're keeping it because it may still prove useful, e.g., a regex like (?:[a-fA-F0-9]{0,4}:){2,7}[a-fA-F0-9]{0,4})\]? could be used to ignore spelling mistakes in ipv6 addresses.
Mechanically, this erases the matching text before the word regex is applied.