-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos from Perl5 (2014-2019) Grand Finale #1106
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 4 4
Lines 727 727
Branches 106 106
=======================================
Hits 664 664
Misses 46 46
Partials 17 17 Continue to review full report at Codecov.
|
codespell_lib/data/dictionary.txt
Outdated
@@ -11180,6 +11207,7 @@ obtaiend->obtained | |||
obtaion->obtain | |||
obtrain->obtain | |||
obtrained->obtained | |||
obverse->observe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a word
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Deleted.
codespell_lib/data/dictionary.txt
Outdated
@@ -11931,6 +11965,9 @@ paticular->particular | |||
paticularly->particularly | |||
patrent->parent, patent, patron, | |||
pattented->patented | |||
patter->pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a word, but maybe we should keep since there will presumably be way more true positives than false positives from including this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like a slippery slope to me; if you're going to do that, can they at least be pulled into a separate dictionary file instead and add the ability to use multiple dictionaries (if not already present). Then there's just the challenge of deciding what typos are sufficiently popular to be in the second file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do?
Delete the word?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
'patter' & 'patters' deleted.
Some typos from https://perl5.git.perl.org/perl.git/search/HEAD?s=typo;st=free
Note:
I would like to thank the Perl5 community for all these misspellings (800+ between 1989 and 2019!)
AS WELL AS their corrections...